Improve SillyHome discovery and feedback learning
This commit is contained in:
@@ -9,6 +9,7 @@ from app.actuators.lifecycle import ActuatorReconciliationService
|
||||
from app.actuators.store import ActuatorStore
|
||||
from app.behavior.engine import BehaviorEngine
|
||||
from app.config import Settings
|
||||
from app.api.v1.actuators import _deduplicate_actuator_ids
|
||||
from app.ha.discovery import DiscoveredEntity
|
||||
from app.ha.discovery import discover_entities
|
||||
from app.ha.history import (
|
||||
@@ -227,3 +228,37 @@ def test_context_options_returns_learnable_entities(tmp_path: Path) -> None:
|
||||
assert "sensor.abstellkammer_illuminance" in entity_ids
|
||||
assert "binary_sensor.abstellkammer_motion" in entity_ids
|
||||
assert "sensor.pfsense_interface_vpn_inbytes" not in entity_ids
|
||||
|
||||
|
||||
def test_actuator_discovery_prefers_light_over_duplicate_switch() -> None:
|
||||
entities = {
|
||||
"light.schreibtisch": HaEntitySummary(
|
||||
entity_id="light.schreibtisch",
|
||||
domain="light",
|
||||
friendly_name="Schreibtisch Licht",
|
||||
device_id="device-1",
|
||||
),
|
||||
"switch.schreibtisch": HaEntitySummary(
|
||||
entity_id="switch.schreibtisch",
|
||||
domain="switch",
|
||||
friendly_name="Schreibtisch Schalter",
|
||||
device_id="device-1",
|
||||
),
|
||||
"cover.rollladen": HaEntitySummary(
|
||||
entity_id="cover.rollladen",
|
||||
domain="cover",
|
||||
friendly_name="Rollladen",
|
||||
device_id="device-2",
|
||||
),
|
||||
}
|
||||
|
||||
result = _deduplicate_actuator_ids(
|
||||
[
|
||||
("switch.schreibtisch", "switch_socket"),
|
||||
("light.schreibtisch", "light"),
|
||||
("cover.rollladen", "cover_shutter"),
|
||||
],
|
||||
entities,
|
||||
)
|
||||
|
||||
assert result == ["cover.rollladen", "light.schreibtisch"]
|
||||
|
||||
@@ -27,6 +27,7 @@ class FakeHaReader(HaReader):
|
||||
entity_id="sensor.temperature",
|
||||
domain="sensor",
|
||||
device_class="temperature",
|
||||
category="temperature",
|
||||
role=EntityRole.MEASUREMENT,
|
||||
learnable=True,
|
||||
reason="Numerischer Messsensor für Zeitreihen und Training.",
|
||||
@@ -116,6 +117,7 @@ def test_discovery_filters_entities() -> None:
|
||||
"device_class": "temperature",
|
||||
"state_class": None,
|
||||
"unit_of_measurement": None,
|
||||
"category": "temperature",
|
||||
"role": "measurement",
|
||||
"learnable": True,
|
||||
"reason": "Numerischer Messsensor für Zeitreihen und Training.",
|
||||
|
||||
Reference in New Issue
Block a user