59
tests/api/test_automations.py
Normal file
59
tests/api/test_automations.py
Normal file
@@ -0,0 +1,59 @@
|
||||
from pathlib import Path
|
||||
|
||||
from fastapi.testclient import TestClient
|
||||
|
||||
from app.automations.store import AutomationStore
|
||||
from app.main import app
|
||||
|
||||
|
||||
def _payload() -> dict[str, object]:
|
||||
return {
|
||||
"alias": "Licht bei Dunkelheit",
|
||||
"description": "Schaltet das Flurlicht unter dem Helligkeitsgrenzwert ein.",
|
||||
"trigger": {"entity_id": "sensor.hall_illuminance", "below": 10},
|
||||
"action": {
|
||||
"service": "light.turn_on",
|
||||
"entity_id": "light.hall",
|
||||
"data": {"brightness_pct": 40},
|
||||
},
|
||||
}
|
||||
|
||||
|
||||
def test_proposal_requires_explicit_approval_before_yaml(tmp_path: Path) -> None:
|
||||
with TestClient(app) as client:
|
||||
app.state.automation_store = AutomationStore(tmp_path)
|
||||
created = client.post("/v1/automations/proposals", json=_payload())
|
||||
proposal_id = created.json()["proposal_id"]
|
||||
blocked = client.get(f"/v1/automations/proposals/{proposal_id}/yaml")
|
||||
approved = client.post(
|
||||
f"/v1/automations/proposals/{proposal_id}/approve",
|
||||
json={"expected_revision": 1},
|
||||
)
|
||||
exported = client.get(f"/v1/automations/proposals/{proposal_id}/yaml")
|
||||
assert created.status_code == 201
|
||||
assert created.json()["status"] == "draft"
|
||||
assert blocked.status_code == 409
|
||||
assert approved.json()["status"] == "approved"
|
||||
assert "service: light.turn_on" in exported.text
|
||||
|
||||
|
||||
def test_proposal_rejects_unsafe_service_domain(tmp_path: Path) -> None:
|
||||
payload = _payload()
|
||||
payload["action"] = {
|
||||
"service": "shell_command.run",
|
||||
"entity_id": "light.hall",
|
||||
"data": {},
|
||||
}
|
||||
with TestClient(app) as client:
|
||||
app.state.automation_store = AutomationStore(tmp_path)
|
||||
response = client.post("/v1/automations/proposals", json=payload)
|
||||
assert response.status_code == 422
|
||||
|
||||
|
||||
def test_proposal_requires_numeric_threshold(tmp_path: Path) -> None:
|
||||
payload = _payload()
|
||||
payload["trigger"] = {"entity_id": "sensor.hall_illuminance"}
|
||||
with TestClient(app) as client:
|
||||
app.state.automation_store = AutomationStore(tmp_path)
|
||||
response = client.post("/v1/automations/proposals", json=payload)
|
||||
assert response.status_code == 422
|
||||
53
tests/automations/test_store.py
Normal file
53
tests/automations/test_store.py
Normal file
@@ -0,0 +1,53 @@
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
from app.automations.models import (
|
||||
AutomationProposal,
|
||||
NumericStateTrigger,
|
||||
ProposalStatus,
|
||||
ServiceAction,
|
||||
)
|
||||
from app.automations.store import AutomationStore
|
||||
|
||||
|
||||
def proposal() -> AutomationProposal:
|
||||
return AutomationProposal(
|
||||
alias="Wohnzimmer bei Kälte heizen",
|
||||
description="Aktiviert den Heizmodus unter 18 Grad.",
|
||||
trigger=NumericStateTrigger(entity_id="sensor.living_room_temperature", below=18.0),
|
||||
action=ServiceAction(
|
||||
service="climate.set_temperature",
|
||||
entity_id="climate.living_room",
|
||||
data={"temperature": 21.0},
|
||||
),
|
||||
)
|
||||
|
||||
|
||||
def test_store_persists_approval_and_exports_yaml(tmp_path: Path) -> None:
|
||||
store = AutomationStore(tmp_path)
|
||||
created = store.create(proposal())
|
||||
approved = store.decide(created.proposal_id, ProposalStatus.APPROVED, 1)
|
||||
yaml = AutomationStore(tmp_path).export_yaml(created.proposal_id)
|
||||
assert approved.status is ProposalStatus.APPROVED
|
||||
assert approved.revision == 2
|
||||
assert "platform: numeric_state" in yaml
|
||||
assert "service: climate.set_temperature" in yaml
|
||||
assert "temperature: 21.0" in yaml
|
||||
|
||||
|
||||
def test_store_requires_approval_and_current_revision(tmp_path: Path) -> None:
|
||||
store = AutomationStore(tmp_path)
|
||||
created = store.create(proposal())
|
||||
with pytest.raises(ValueError, match="freigegebene"):
|
||||
store.export_yaml(created.proposal_id)
|
||||
with pytest.raises(ValueError, match="Revision"):
|
||||
store.decide(created.proposal_id, ProposalStatus.APPROVED, 2)
|
||||
|
||||
|
||||
def test_store_allows_only_one_decision(tmp_path: Path) -> None:
|
||||
store = AutomationStore(tmp_path)
|
||||
created = store.create(proposal())
|
||||
store.decide(created.proposal_id, ProposalStatus.REJECTED, 1)
|
||||
with pytest.raises(ValueError, match="bereits entschieden"):
|
||||
store.decide(created.proposal_id, ProposalStatus.APPROVED, 2)
|
||||
@@ -9,10 +9,12 @@ def test_load_settings_reads_documented_environment(monkeypatch: MonkeyPatch) ->
|
||||
monkeypatch.setenv("SILLYHOME_HA_URL", "http://ha.local:8123")
|
||||
monkeypatch.setenv("SILLYHOME_HA_TOKEN", "secret")
|
||||
monkeypatch.setenv("SILLYHOME_MODEL_STORE", "/tmp/models")
|
||||
monkeypatch.setenv("SILLYHOME_AUTOMATION_STORE", "/tmp/automations")
|
||||
|
||||
settings = load_settings()
|
||||
|
||||
assert settings.ha_url == "http://ha.local:8123"
|
||||
assert settings.ha_token == "secret"
|
||||
assert settings.model_store == "/tmp/models"
|
||||
assert settings.automation_store == "/tmp/automations"
|
||||
assert settings.ha_configured
|
||||
|
||||
Reference in New Issue
Block a user